Comments on: Using Phing to automate JavaScript and CSS Minimization http://www.zachleat.com/web/using-phing-to-automate-javascript-and-css-minimization/ Wed, 16 May 2012 21:15:15 +0000 hourly 1 By: iVariable http://www.zachleat.com/web/using-phing-to-automate-javascript-and-css-minimization/comment-page-1/#comment-2403 iVariable Thu, 23 Jun 2011 05:25:07 +0000 http://www.zachleat.com/web/2007/08/11/using-phing-to-automate-javascript-and-css-minimization/#comment-2403 Thanks a lot! You've saved me some time ^_^ Thanks a lot! You’ve saved me some time ^_^

]]> By: Tristan Eastburn http://www.zachleat.com/web/using-phing-to-automate-javascript-and-css-minimization/comment-page-1/#comment-1908 Tristan Eastburn Fri, 05 Mar 2010 00:28:32 +0000 http://www.zachleat.com/web/2007/08/11/using-phing-to-automate-javascript-and-css-minimization/#comment-1908 OK I spoke a little soon :) Line 216 (preserveCss) also need the fix from the above comment. Also, properties with number values, i.e. lines 199, 203 and 209 (optimizeShortand, propertyCase and mergeSelectors) need to be changed from: if(!empty($this->propertyName)) to: if(isset($this->propertyName)) since they all have number values, empty() will fail for their 0 value. OK I spoke a little soon :)

Line 216 (preserveCss) also need the fix from the above comment.

Also, properties with number values, i.e. lines 199, 203 and 209 (optimizeShortand, propertyCase and mergeSelectors) need to be changed from:
if(!empty($this->propertyName))

to:
if(isset($this->propertyName))

since they all have number values, empty() will fail for their 0 value.

]]> By: Tristan Eastburn http://www.zachleat.com/web/using-phing-to-automate-javascript-and-css-minimization/comment-page-1/#comment-1907 Tristan Eastburn Thu, 04 Mar 2010 23:29:22 +0000 http://www.zachleat.com/web/2007/08/11/using-phing-to-automate-javascript-and-css-minimization/#comment-1907 Thanks a lot for these filters! They work quite well so far and saved me a lot of time. I know you wrote this article 2.5 years ago, but I ran across a tiny bug with in the CssTidyFilter where the "remove_last_;" property doesn't get set properly, though. The bug appears for me with Phing 2.4.0 and CssTidy 1.3 on Ubuntu 9.10 Karmic, haven't tested other versions. My build file has this line: $lt;param name="remove_last_;" value="true"/> And putting an echo in CssTidyFilter after calling getParam() shows that somewhere along the way it gets changed: var_dump($this->removeLastSemicolon) = string(1) "1" So the following assignment fails: $css->set_cfg('remove_last_;',$this->removeLastSemicolon=='true'?true:false); I will send a patch to the author, but in case he can't get to it or no longer maintains this project, you can just do this (around line 202): $css->set_cfg('remove_last_;',!empty($this->removeLastSemicolon)?true:false); This fix may or may not work for other properties, I have not tried it. The other properties I use ('merge_selectors', 'template' and 'preserveCss') seem to work fine. Another suggested change would be to use "require_once()" instead of "include_once()" as the script should fail if it can't find the files it depends on. Thanks a lot for these filters! They work quite well so far and saved me a lot of time.

I know you wrote this article 2.5 years ago, but I ran across a tiny bug with in the CssTidyFilter where the “remove_last_;” property doesn’t get set properly, though. The bug appears for me with Phing 2.4.0 and CssTidy 1.3 on Ubuntu 9.10 Karmic, haven’t tested other versions.

My build file has this line:
$lt;param name=”remove_last_;” value=”true”/>

And putting an echo in CssTidyFilter after calling getParam() shows that somewhere along the way it gets changed:
var_dump($this->removeLastSemicolon) = string(1) “1″

So the following assignment fails:
$css->set_cfg(‘remove_last_;’,$this->removeLastSemicolon==’true’?true:false);

I will send a patch to the author, but in case he can’t get to it or no longer maintains this project, you can just do this (around line 202):
$css->set_cfg(‘remove_last_;’,!empty($this->removeLastSemicolon)?true:false);

This fix may or may not work for other properties, I have not tried it. The other properties I use (‘merge_selectors’, ‘template’ and ‘preserveCss’) seem to work fine.

Another suggested change would be to use “require_once()” instead of “include_once()” as the script should fail if it can’t find the files it depends on.

]]>